Skip to content

HADOOP-17718. Explicitly set locale in the Dockerfile.#3034

Merged
jojochuang merged 2 commits intoapache:trunkfrom
jojochuang:HADOOP-17718
May 21, 2021
Merged

HADOOP-17718. Explicitly set locale in the Dockerfile.#3034
jojochuang merged 2 commits intoapache:trunkfrom
jojochuang:HADOOP-17718

Conversation

@jojochuang
Copy link
Contributor

@jojochuang jojochuang commented May 21, 2021

No description provided.

@jojochuang
HADOOP-17718. Explicitly set locale in the Dockerfile.
5d346ea 
Change-Id: Ia1924fa599cdbde9a06e79fe104f88ce44349bb3
@hadoop-yetus
Copy link

hadoop-yetus commented May 21, 2021

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3034/1/console in case of problems.

@hadoop-yetus
Copy link

hadoop-yetus commented May 21, 2021

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 10m 49s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+0 🆗 mvndep 12m 29s Maven dependency ordering for branch
+1 💚 shadedclient 15m 33s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 hadolint 0m 2s No new issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shadedclient 15m 12s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
56m 30s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3034/1/artifact/out/Dockerfile
GITHUB PR #3034
Optional Tests dupname asflicense codespell hadolint shellcheck shelldocs
uname Linux 26defcdfc397 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 5d346ea
Max. process+thread count 593 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3034/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0 hadolint=1.11.1-0-g0e692dd
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka
aajisaka requested changes May 21, 2021
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you set locale in the other Dockerfiles?

@jojochuang
Set locale for the aarch64, centos7 and centos8 images.
1701137 
Change-Id: I4e0719b737d5d1f34b79fedf83599e7a861992f7
@hadoop-yetus
Copy link

hadoop-yetus commented May 21, 2021

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3034/2/console in case of problems.

@hadoop-yetus
Copy link

hadoop-yetus commented May 21, 2021

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 9m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+0 🆗 mvndep 16m 5s Maven dependency ordering for branch
+1 💚 shadedclient 13m 8s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 hadolint 0m 9s No new issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shadedclient 13m 2s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
54m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3034/2/artifact/out/Dockerfile
GITHUB PR #3034
Optional Tests dupname asflicense codespell hadolint shellcheck shelldocs
uname Linux 1a6bc7f5637d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1701137
Max. process+thread count 684 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3034/2/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0 hadolint=1.11.1-0-g0e692dd
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka
aajisaka approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jojochuang jojochuang merged commit ad923ad into apache:trunk May 21, 2021
@jojochuang
Copy link
Contributor Author

jojochuang commented May 21, 2021

Thx!

asfgit pushed a commit that referenced this pull request May 21, 2021
@jojochuang
HADOOP-17718. Explicitly set locale in the Dockerfile. (#3034)
5e09d38 
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit ad923ad)

Conflicts:
	dev-support/docker/Dockerfile_centos_7
	dev-support/docker/Dockerfile_centos_8
asfgit pushed a commit that referenced this pull request May 21, 2021
@jojochuang
HADOOP-17718. Explicitly set locale in the Dockerfile. (#3034)
bcd9fa6 
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit ad923ad)

Conflicts:
	dev-support/docker/Dockerfile_centos_7
	dev-support/docker/Dockerfile_centos_8
(cherry picked from commit 5e09d38)
@jojochuang
Copy link
Contributor Author

jojochuang commented May 21, 2021

Cherrypicked the commit to branch-3.3 and 3.3.1 (removed the two Docker files not available in 3.3.x)

kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@jojochuang
HADOOP-17718. Explicitly set locale in the Dockerfile. (apache#3034)
9cd7e90 
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
iwasakims pushed a commit that referenced this pull request Mar 10, 2022
@jojochuang @iwasakims
HADOOP-17718. Explicitly set locale in the Dockerfile. (#3034)
c531613 
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit ad923ad)

Conflicts:
	dev-support/docker/Dockerfile_centos_7
	dev-support/docker/Dockerfile_centos_8
(cherry picked from commit 5e09d38)

Conflicts:
	dev-support/docker/Dockerfile_aarch64
iwasakims pushed a commit that referenced this pull request Mar 10, 2022
@jojochuang @iwasakims
HADOOP-17718. Explicitly set locale in the Dockerfile. (#3034)
b3a75fd 
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit ad923ad)

Conflicts:
	dev-support/docker/Dockerfile_centos_7
	dev-support/docker/Dockerfile_centos_8
(cherry picked from commit 5e09d38)

Conflicts:
	dev-support/docker/Dockerfile_aarch64
(cherry picked from commit c531613)
iwasakims pushed a commit that referenced this pull request Apr 14, 2022
@jojochuang @iwasakims
HADOOP-17718. Explicitly set locale in the Dockerfile. (#3034)
9a687f4 
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit ad923ad)

Conflicts:
	dev-support/docker/Dockerfile_centos_7
	dev-support/docker/Dockerfile_centos_8
(cherry picked from commit 5e09d38)

Conflicts:
	dev-support/docker/Dockerfile_aarch64
(cherry picked from commit c531613)

Conflicts:
	dev-support/docker/Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aajisaka aajisaka aajisaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jojochuang @hadoop-yetus @aajisaka